Skip to content

WIP: Improve token amount long to use same formatting used in Safe - #508

Closed
evanaronson wants to merge 7 commits into
mainfrom
token-amount-long
Closed

WIP: Improve token amount long to use same formatting used in Safe#508
evanaronson wants to merge 7 commits into
mainfrom
token-amount-long

Conversation

@evanaronson

@evanaronson evanaronson commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Description

We essentially have no "long" formatting because long is the same as being unformatted.

Before:
image

After:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 19, 2025

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
@evanaronson
evanaronson deleted the token-amount-long branch June 19, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant